Ensure libraries always have at least one top-level class and therefore at least one script.

Ensure libraries always have at least one top-level class and therefore at least one script.

BUG=http://dartbug.com/23483
R=hausner@google.com

Committed: https://github.com/dart-lang/sdk/commit/daf6fb60918afa29b81790bc98b62a9549147e6c

[rmacnak, 2015-05-19 01:43:14]

rmacnak@google.com changed reviewers:
+ hausner@google.com

[hausner, 2015-05-19 05:43:04]

LGTM with comment

https://codereview.chromium.org/1131793012/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1131793012/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:5979: library_.AddAnonymousClass(toplevel_class);
A library with 100 part files will now have 100 top-level classes, right?
Instead of creating a TL class unconditionally, you could change the old code
to:

if ((library_ has no top-level classes) || 
    (top_level.fields.Length() > 0) || (top_level.functions.Length() > 0)) {
....

[rmacnak, 2015-05-19 15:57:41]

https://codereview.chromium.org/1131793012/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1131793012/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:5979: library_.AddAnonymousClass(toplevel_class);
On 2015/05/19 05:43:03, hausner wrote:
> A library with 100 part files will now have 100 top-level classes, right?
> Instead of creating a TL class unconditionally, you could change the old code
> to:
> 
> if ((library_ has no top-level classes) || 
>     (top_level.fields.Length() > 0) || (top_level.functions.Length() > 0)) {
> ....

Done.

[rmacnak, 2015-05-19 15:58:29]

Committed patchset #2 (id:20001) manually as
daf6fb60918afa29b81790bc98b62a9549147e6c (presubmit successful).