Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1131673004: Use WorkManager(s) in AnalysisDriver. (Closed)

Created:
5 years, 7 months ago by scheglov
Modified:
5 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Use WorkManager(s) in AnalysisDriver. Install DartWorkManager in AnalysisContextImpl. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45690

Patch Set 1 #

Total comments: 3

Patch Set 2 : Undo sorting or context_test.dart file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -160 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 8 chunks +18 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart_work_manager.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/driver.dart View 6 chunks +87 lines, -46 lines 0 comments Download
M pkg/analyzer/test/src/context/abstract_context.dart View 4 chunks +2 lines, -7 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_work_manager_test.dart View 2 chunks +15 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/driver_test.dart View 14 chunks +131 lines, -100 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
5 years, 7 months ago (2015-05-10 05:40:59 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/1131673004/diff/1/pkg/analyzer/lib/src/task/dart_work_manager.dart File pkg/analyzer/lib/src/task/dart_work_manager.dart (right): https://codereview.chromium.org/1131673004/diff/1/pkg/analyzer/lib/src/task/dart_work_manager.dart#newcode111 pkg/analyzer/lib/src/task/dart_work_manager.dart:111: WorkOrderPriority getNextResultPriority() { Do you have a plan ...
5 years, 7 months ago (2015-05-11 13:59:21 UTC) #2
scheglov
Sorry for the sorting issue. I undo it and updated the CL. https://codereview.chromium.org/1131673004/diff/1/pkg/analyzer/lib/src/task/dart_work_manager.dart File pkg/analyzer/lib/src/task/dart_work_manager.dart ...
5 years, 7 months ago (2015-05-11 14:03:37 UTC) #3
Brian Wilkerson
LGTM
5 years, 7 months ago (2015-05-11 14:07:22 UTC) #4
scheglov
5 years, 7 months ago (2015-05-11 15:16:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 45690 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698