Refactor the InstanceFunctionLookupStub.

Refactor the InstanceFunctionLookupStub.

The stub is used in the case that an IC miss handler cannot find a
cacheable target.  It handles implicit closures, calls to instance
fields, and no such method.

Refactor the stub to make a single call into the runtime.

BUG=

[Kevin Millikin (Google), 2012-12-12 14:18:38]

https://codereview.chromium.org/11316353/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/11316353/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1270: instance ^= value.raw();
I'm not sure what compels value to be an Instance.  The existing code returned
an Object from one runtime call and then treated it as an
Instance::CheckedHandle on the next one, so this should be equivalent to what we
had before.

[regis, 2012-12-12 17:37:38]

LGTM

Thanks for doing this!

https://codereview.chromium.org/11316353/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/11316353/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1270: instance ^= value.raw();
On 2012/12/12 14:18:38, kmillikin wrote:
> I'm not sure what compels value to be an Instance.  The existing code returned
> an Object from one runtime call and then treated it as an
> Instance::CheckedHandle on the next one, so this should be equivalent to what
we
> had before.

I am not sure it answers your question, but all values returned by dart
functions are instances. A value of type Object is also an instance.

[Kevin Millikin (Google), 2012-12-12 19:55:40]

Committed as https://code.google.com/p/dart/source/detail?r=16057