Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 11316283: Eliminate old style import from language tests (Closed)

Created:
8 years ago by hausner
Modified:
8 years ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Eliminate old style import from language tests Also implement multi-part library names. Committed: https://code.google.com/p/dart/source/detail?r=15612

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -350 lines) Patch
M runtime/vm/parser.cc View 1 2 3 3 chunks +16 lines, -8 lines 0 comments Download
M tests/language/application_negative_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/application_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/arithmetic_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/call_constructor_on_unresolvable_class_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/closure_type_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/const_var_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/const_var_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/ct_const4_lib.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/ct_const4_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/cyclic_import_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/default_factory_library.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/default_factory_library_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/disable_privacy_lib.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/disable_privacy_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/function_type_alias3_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/generic_instanceof_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/getter_setter_in_lib.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/getter_setter_in_lib_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/hello_script_lib.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/hello_script_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/illegal_invocation_lib.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/illegal_invocation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/import_collection_no_prefix_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/import_core_no_prefix_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/import_core_prefix_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/import_core_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/intrinsified_methods_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/issue1363_lib.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/issue1363_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/language.status View 1 2 7 chunks +35 lines, -39 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/lazy_static6_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/library1.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/library10.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/language/library11.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/library12.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/library1_negative_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/library1_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/library2.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/library3.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/library4.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/library5_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/library5a.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/library5b.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/library6.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/library_a.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/library_b.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/library_c.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/library_d.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/library_e.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/library_f.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/library_negative_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/library_prefixes_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/library_private_in_constructor_a.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/library_private_in_constructor_b.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/library_private_in_constructor_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/library_same_name_used_lib1.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/library_same_name_used_lib2.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/library_same_name_used_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/many_generic_instanceof_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/many_overridden_no_such_method_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/math_vm_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/metadata_lib.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/metadata_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/multi_pass2_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/multi_pass_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/numbers_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/overridden_no_such_method_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/prefix101_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/prefix10_negative_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/prefix10_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/prefix11_negative_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/prefix11_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/prefix12_negative_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/prefix12_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/prefix13_negative_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/prefix14_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/prefix15_negative_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/prefix15_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/prefix16_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/prefix17_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/prefix18_negative_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
D tests/language/prefix19_negative_test.dart View 1 chunk +0 lines, -13 lines 0 comments Download
M tests/language/prefix1_negative_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D tests/language/prefix20_negative_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M tests/language/prefix21_bad_lib.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/prefix21_good_lib.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/prefix21_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/prefix22_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/prefix23_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/prefix2_negative_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/prefix3_negative_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/prefix4_negative_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/prefix5_negative_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/prefix6_negative_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/prefix7_negative_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/prefix_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/prefix_test1.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/prefix_test2.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/private2_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/private3_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language/private_member1_lib_b.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/private_member1_negative_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/private_member2_lib_b.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/private_member2_negative_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/private_member3_lib_b.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/private_member3_negative_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/private_member_lib_b.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/private_member_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/private_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language/script1_negative_lib.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/script1_negative_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/script2_negative_lib.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/script2_negative_source.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/script2_negative_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/script_lib.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/script_negative_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/source_self_negative_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
D tests/language/string_escape1_negative_test.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language/string_escape2_negative_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D tests/language/string_escape3_negative_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M tests/language/string_escape3_negative_test_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/sub/sub.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/top_level_entry_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/top_level_multiple_files_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/top_level_non_prefixed_library_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/top_level_prefixed_declaration_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/typed_message_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
It's actually a small change...
8 years ago (2012-11-30 22:46:31 UTC) #1
srdjan
LGTM https://codereview.chromium.org/11316283/diff/9001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/11316283/diff/9001/runtime/vm/parser.cc#newcode4083 runtime/vm/parser.cc:4083: *ExpectIdentifier("library name part expected after dot")); 'part' is ...
8 years ago (2012-11-30 22:54:42 UTC) #2
hausner
8 years ago (2012-11-30 23:10:01 UTC) #3
Thank you.

https://codereview.chromium.org/11316283/diff/9001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/11316283/diff/9001/runtime/vm/parser.cc#newco...
runtime/vm/parser.cc:4083: *ExpectIdentifier("library name part expected after
dot"));
On 2012/11/30 22:54:42, srdjan wrote:
> 'part' is confusing in the context of libraries.

Reworded message as discussed.

https://codereview.chromium.org/11316283/diff/9001/runtime/vm/parser.cc#newco...
runtime/vm/parser.cc:4298: ExpectIdentifier("library name part expected after
dot");
On 2012/11/30 22:54:42, srdjan wrote:
> ditto

ditto

Powered by Google App Engine
This is Rietveld 408576698