Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11316264: Snapshotting changes for dart:html_common (Closed)

Created:
8 years ago by blois
Modified:
8 years ago
Reviewers:
Anton Muhin, sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Include dart:html_common in the Dartium snapshot. BUG= Committed: https://code.google.com/p/dart/source/detail?r=15621

Patch Set 1 #

Patch Set 2 : Fixes to allow dart:html_common to be included in Dartium snapshots. #

Total comments: 1

Patch Set 3 : Sync to latest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+852 lines, -1747 lines) Patch
M sdk/lib/_internal/compiler/implementation/compiler.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/native_handler.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/libraries.dart View 1 1 chunk +7 lines, -0 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 75 chunks +354 lines, -719 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 39 chunks +306 lines, -365 lines 0 comments Download
M sdk/lib/html/docs/svg_docs.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + sdk/lib/html/html_common/collections.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + sdk/lib/html/html_common/conversions.dart View 1 11 chunks +22 lines, -137 lines 0 comments Download
A + sdk/lib/html/html_common/html_common.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + sdk/lib/html/html_common/html_common_dart2js.dart View 1 1 chunk +3 lines, -4 lines 0 comments Download
M sdk/lib/html/scripts/generator.py View 1 2 9 chunks +22 lines, -23 lines 0 comments Download
D sdk/lib/html/src/_Collections.dart View 1 1 chunk +0 lines, -61 lines 0 comments Download
M sdk/lib/html/src/dart2js_Conversions.dart View 1 3 chunks +2 lines, -306 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/html_dart2js.darttemplate View 1 2 chunks +1 line, -1 line 0 comments Download
M sdk/lib/html/templates/html/dartium/html_dartium.darttemplate View 1 2 chunks +1 line, -1 line 0 comments Download
M sdk/lib/html/templates/html/impl/impl_Node.darttemplate View 1 1 chunk +6 lines, -6 lines 0 comments Download
M sdk/lib/html/templates/immutable_list_mixin.darttemplate View 1 1 chunk +6 lines, -6 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 2 9 chunks +54 lines, -54 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 2 9 chunks +54 lines, -54 lines 0 comments Download
M tools/create_sdk.py View 1 2 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
blois
8 years ago (2012-11-30 03:29:49 UTC) #1
blois
8 years ago (2012-11-30 03:30:39 UTC) #2
Anton Muhin
lgtm
8 years ago (2012-11-30 20:30:27 UTC) #3
sra1
8 years ago (2012-11-30 21:32:05 UTC) #4 
LGTM.

https://chromiumcodereview.appspot.com/11316264/diff/2001/sdk/lib/html/script...
File sdk/lib/html/scripts/generator.py (right):

https://chromiumcodereview.appspot.com/11316264/diff/2001/sdk/lib/html/script...
sdk/lib/html/scripts/generator.py:1089: 'FileList': TypeData(clazz='Interface',
item_type='File'),
I believe if you add dart_type='List<File>' then the functions returning
FileList will return List<File>.

Powered by Google App Engine
This is Rietveld 408576698