Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 11316241: Put back the unit test on optimizing removeLast to pop. Also don't forget that jsArrayRemoveLast mi… (Closed)

Created:
8 years ago by ngeoffray
Modified:
8 years ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Put back the unit test on optimizing removeLast to pop. Also don't forget that jsArrayRemoveLast might be null in case of unit tests. Committed: https://code.google.com/p/dart/source/detail?r=15506

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -18 lines) Patch
M sdk/lib/_internal/compiler/implementation/ssa/codegen.dart View 1 chunk +21 lines, -17 lines 0 comments Download
M tests/compiler/dart2js/value_range_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ngeoffray
TBR to unbreak the build
8 years ago (2012-11-29 09:33:10 UTC) #1
kasperl
8 years ago (2012-11-29 09:41:55 UTC) #2
Message was sent while issue was closed.
LGTM!

Powered by Google App Engine
This is Rietveld 408576698