Issue 11316144: Remove output directory from library path on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11316144: Remove output directory from library path on Linux. (Closed)

Created:
8 years, 1 month ago by Mads Ager (google)

Modified:
8 years, 1 month ago

Reviewers:
Bill Hesse, Søren Gjesse, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove output directory from library path on Linux. Move the setting of -rdynamic to the two executables that need it (dart, dart_no_snapshot). It is needed to allow dynamically loaded libraries to lookup the API symbols in the binary. We use that for native extensions. R=whesse@google.com,iposva@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=15258

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -9 lines)			Patch
	M	runtime/bin/bin.gypi	View		2 chunks	+17 lines, -2 lines	0 comments	Download
	M	tools/gyp/configurations_make.gypi	View		2 chunks	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages