Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 11316108: Correct file names for tests in tests/language. (Closed)

Created:
8 years, 1 month ago by Florian Schneider
Modified:
8 years, 1 month ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org, karlklose, ngeoffray
Visibility:
Public.

Description

Correct file names for tests in tests/language to run them in test.py. Those tests were previously not run because of the missing _test suffix. Changed the test expectations for type_variable_shadows_class_test until it is fixed. Corrected syntax error in optimized_lists.dart and removed invalid expectation from mint_arithmetic_test.dart. Added failing tests to the status file with the corresponding issue #. Split double_to_string_test into two files where one contains all the ones failing with dart2js. BUG=dart:643, dart:1533 Committed: https://code.google.com/p/dart/source/detail?r=15193

Patch Set 1 #

Patch Set 2 : fixed status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -589 lines) Patch
D tests/language/allocate_large_object.dart View 1 1 chunk +0 lines, -44 lines 0 comments Download
A + tests/language/allocate_large_object_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/language/deopt_smi_op.dart View 1 1 chunk +0 lines, -33 lines 0 comments Download
A + tests/language/deopt_smi_op_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/language/double_int_to_string_test.dart View 1 1 chunk +18 lines, -0 lines 0 comments Download
D tests/language/double_to_string.dart View 1 1 chunk +0 lines, -65 lines 0 comments Download
A + tests/language/double_to_string_test.dart View 1 3 chunks +0 lines, -11 lines 0 comments Download
D tests/language/exception_in_increment.dart View 1 1 chunk +0 lines, -24 lines 0 comments Download
A + tests/language/exception_in_increment_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/language/inline_add_constants_to_initial_env.dart View 1 1 chunk +0 lines, -15 lines 0 comments Download
A + tests/language/inline_add_constants_to_initial_env_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/language/inline_closure_with_constant_arguments.dart View 1 1 chunk +0 lines, -20 lines 0 comments Download
A + tests/language/inline_closure_with_constant_arguments_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +4 lines, -0 lines 0 comments Download
D tests/language/mint_arithmetic.dart View 1 1 chunk +0 lines, -85 lines 0 comments Download
A + tests/language/mint_arithmetic_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
D tests/language/mint_compares.dart View 1 1 chunk +0 lines, -96 lines 0 comments Download
A + tests/language/mint_compares_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/language/optimize_redundant_array_load.dart View 1 1 chunk +0 lines, -29 lines 0 comments Download
A + tests/language/optimize_redundant_array_load_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/language/optimized_constant_array_string_access.dart View 1 1 chunk +0 lines, -49 lines 0 comments Download
A + tests/language/optimized_constant_array_string_access_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/language/optimized_hoisting_checked_mode_assert.dart View 1 1 chunk +0 lines, -20 lines 0 comments Download
A + tests/language/optimized_hoisting_checked_mode_assert_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/language/optimized_lists.dart View 1 1 chunk +0 lines, -29 lines 0 comments Download
A + tests/language/optimized_lists_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/language/optimized_string_charcodeat.dart View 1 1 chunk +0 lines, -51 lines 0 comments Download
A + tests/language/optimized_string_charcodeat_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/language/type_variable_shadows_class.dart View 1 1 chunk +0 lines, -27 lines 0 comments Download
A + tests/language/type_variable_shadows_class_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Florian Schneider
8 years, 1 month ago (2012-11-21 10:17:10 UTC) #1
Bill Hesse
8 years, 1 month ago (2012-11-21 11:11:58 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698