Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 11316102: Add utility methods to write the contents of a file as one operation. (Closed)

Created:
8 years, 1 month ago by Mads Ager (google)
Modified:
8 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add utility methods to write the contents of a file as one operation. We already have them for reading and it makes sense to have them for writing as well. We should update the positional arguments in the dart:io library to be named optional arguments. I'd like to do that in a separate patch. R=sgjesse@google.com BUG=dartbug.com/4798 Committed: https://code.google.com/p/dart/source/detail?r=15149

Patch Set 1 #

Total comments: 5

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -31 lines) Patch
M sdk/lib/io/file.dart View 1 chunk +54 lines, -0 lines 0 comments Download
M sdk/lib/io/file_impl.dart View 1 1 chunk +46 lines, -0 lines 0 comments Download
M tests/standalone/io/file_non_ascii_sync_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M tests/standalone/io/file_non_ascii_test.dart View 1 1 chunk +18 lines, -22 lines 0 comments Download
A tests/standalone/io/file_write_as_test.dart View 1 1 chunk +79 lines, -0 lines 0 comments Download
M tests/standalone/io/process_non_ascii_test.dart View 1 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
8 years, 1 month ago (2012-11-20 12:31:49 UTC) #1
Søren Gjesse
8 years, 1 month ago (2012-11-20 13:23:34 UTC) #2
lgtm

https://codereview.chromium.org/11316102/diff/1/sdk/lib/io/file_impl.dart
File sdk/lib/io/file_impl.dart (right):

https://codereview.chromium.org/11316102/diff/1/sdk/lib/io/file_impl.dart#new...
sdk/lib/io/file_impl.dart:668: stream.write(bytes);
You could just do stream.close() right after stream.write and place a handler on
onClose instead of on onNoPendingWrites.

https://codereview.chromium.org/11316102/diff/1/tests/standalone/io/file_writ...
File tests/standalone/io/file_write_as_test.dart (right):

https://codereview.chromium.org/11316102/diff/1/tests/standalone/io/file_writ...
tests/standalone/io/file_write_as_test.dart:31: f.writeAsBytes(data).then((_){
Maybe expect _ is f.

https://codereview.chromium.org/11316102/diff/1/tests/standalone/io/file_writ...
tests/standalone/io/file_write_as_test.dart:34: f.writeAsBytes(data,
FileMode.APPEND).then((_) {
Ditto.

https://codereview.chromium.org/11316102/diff/1/tests/standalone/io/file_writ...
tests/standalone/io/file_write_as_test.dart:50: f.writeAsString(data).then((_){
Ditto.

https://codereview.chromium.org/11316102/diff/1/tests/standalone/io/file_writ...
tests/standalone/io/file_write_as_test.dart:53: f.writeAsString(data,
FileMode.APPEND).then((_) {
Ditto.

Powered by Google App Engine
This is Rietveld 408576698