Change the HTTP close handling

Change the HTTP close handling

Whenever the client closes its connection the server will follow and
close as well.

R=ager@google.com

BUG=dart:4652
Committed: https://code.google.com/p/dart/source/detail?r=15135

[Mads Ager (google), 2012-11-20 08:04:28]

LGTM

https://codereview.chromium.org/11316080/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/11316080/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:17: if (!connection._isWriteClosed &&
!connection._isReadClosed) return;
Maybe remove the negations and make this:

if (connection._isWriteClosed || connection._isReadClose) {
  // do stuff
}

https://codereview.chromium.org/11316080/diff/1/sdk/lib/io/http_parser.dart
File sdk/lib/io/http_parser.dart (right):

https://codereview.chromium.org/11316080/diff/1/sdk/lib/io/http_parser.dart#n...
sdk/lib/io/http_parser.dart:626: print("$_requestParser $e");
Remove debug print.

https://codereview.chromium.org/11316080/diff/1/tests/standalone/io/http_conn...
File tests/standalone/io/http_connection_close_test.dart (right):

https://codereview.chromium.org/11316080/diff/1/tests/standalone/io/http_conn...
tests/standalone/io/http_connection_close_test.dart:68: //print(bytes);
Remove?

[Søren Gjesse, 2012-11-20 08:15:11]

https://codereview.chromium.org/11316080/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/11316080/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:17: if (!connection._isWriteClosed &&
!connection._isReadClosed) return;
On 2012/11/20 08:04:28, Mads Ager wrote:
> Maybe remove the negations and make this:
> 
> if (connection._isWriteClosed || connection._isReadClose) {
>   // do stuff
> }

Much better, done.

https://codereview.chromium.org/11316080/diff/1/sdk/lib/io/http_parser.dart
File sdk/lib/io/http_parser.dart (right):

https://codereview.chromium.org/11316080/diff/1/sdk/lib/io/http_parser.dart#n...
sdk/lib/io/http_parser.dart:626: print("$_requestParser $e");
On 2012/11/20 08:04:28, Mads Ager wrote:
> Remove debug print.

Done.

https://codereview.chromium.org/11316080/diff/1/tests/standalone/io/http_conn...
File tests/standalone/io/http_connection_close_test.dart (right):

https://codereview.chromium.org/11316080/diff/1/tests/standalone/io/http_conn...
tests/standalone/io/http_connection_close_test.dart:68: //print(bytes);
On 2012/11/20 08:04:28, Mads Ager wrote:
> Remove?

Done.