Issue 11316077: Remove non-ascii file names from repo and generate them in tests instead.

Issue 11316077: Remove non-ascii file names from repo and generate them in tests instead. (Closed)

Created:
8 years, 1 month ago by Mads Ager (google)

Modified:
8 years, 1 month ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove non-ascii file names from repo and generate them in tests instead. R=ricow@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=15073

Patch Set 2 : Remove last file #

Total comments: 6

Patch Set 3 : Address comments. #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -56 lines)			Patch
M	tests/standalone/io/directory_non_ascii_sync_test.dart	View	1 2	1 chunk	+12 lines, -10 lines	0 comments	Download
M	tests/standalone/io/directory_non_ascii_test.dart	View	1 2	1 chunk	+18 lines, -12 lines	0 comments	Download
M	tests/standalone/io/file_non_ascii_sync_test.dart	View		1 chunk	+19 lines, -12 lines	0 comments	Download
M	tests/standalone/io/file_non_ascii_test.dart	View	1 2	1 chunk	+36 lines, -18 lines	0 comments	Download
M	tests/standalone/io/process_non_ascii_test.dart	View		1 chunk	+24 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

The code review tools does not like to show it but this also removes the ...

8 years, 1 month ago (2012-11-19 12:07:02 UTC) #1

ricow1

LGTM https://codereview.chromium.org/11316077/diff/2001/tests/standalone/io/directory_non_ascii_sync_test.dart File tests/standalone/io/directory_non_ascii_sync_test.dart (right): https://codereview.chromium.org/11316077/diff/2001/tests/standalone/io/directory_non_ascii_sync_test.dart#newcode21 tests/standalone/io/directory_non_ascii_sync_test.dart:21: tempDir.deleteSync(recursive: true); maybe assert that the two paths ...

8 years, 1 month ago (2012-11-19 12:20:53 UTC) #2

Mads Ager (google)

8 years, 1 month ago (2012-11-19 12:26:20 UTC) #3

Thanks!

https://codereview.chromium.org/11316077/diff/2001/tests/standalone/io/direct...
File tests/standalone/io/directory_non_ascii_sync_test.dart (right):

https://codereview.chromium.org/11316077/diff/2001/tests/standalone/io/direct...
tests/standalone/io/directory_non_ascii_sync_test.dart:21:
tempDir.deleteSync(recursive: true);
On 2012/11/19 12:20:54, ricow1 wrote:
> maybe assert that the two paths does not still exist (i.e.,
> Expect.isTrue(d.existsSync() && temp2.existsSync() )
> Also, why is one called d and one is called temp2?

Renamed:
d -> nonAsciiDir
temp2 -> temp

Added asserts.

https://codereview.chromium.org/11316077/diff/2001/tests/standalone/io/direct...
File tests/standalone/io/directory_non_ascii_test.dart (right):

https://codereview.chromium.org/11316077/diff/2001/tests/standalone/io/direct...
tests/standalone/io/directory_non_ascii_test.dart:28: port.close();
On 2012/11/19 12:20:54, ricow1 wrote:
> same suggestion as the other test, should we assert that the directories does
no
> longer exist?

Done.

https://codereview.chromium.org/11316077/diff/2001/tests/standalone/io/file_n...
File tests/standalone/io/file_non_ascii_test.dart (right):

https://codereview.chromium.org/11316077/diff/2001/tests/standalone/io/file_n...
tests/standalone/io/file_non_ascii_test.dart:34: nonAsciiFile.length().then((l)
{
On 2012/11/19 12:20:54, ricow1 wrote:
> l -> length?

Done.

Expand Messages | Collapse Messages