Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 11316059: Add List.first. (Closed)

Created:
8 years, 1 month ago by floitsch
Modified:
8 years, 1 month ago
Reviewers:
sra1
CC:
reviews_dartlang.org, Lasse Reichstein Nielsen
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase after revert. #

Patch Set 3 : Add dart2js interceptor and add test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -29 lines) Patch
M runtime/lib/array.dart View 2 chunks +8 lines, -0 lines 0 comments Download
M runtime/lib/byte_array.dart View 2 chunks +8 lines, -0 lines 0 comments Download
M runtime/lib/growable_array.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M samples/swarm/swarm_ui_lib/observable/observable.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/interceptors.dart View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M sdk/lib/core/list.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M sdk/lib/core/sequences.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 38 chunks +75 lines, -6 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 38 chunks +75 lines, -6 lines 0 comments Download
M sdk/lib/html/src/FilteredElementList.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_Element.darttemplate View 3 chunks +7 lines, -4 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_NodeList.darttemplate View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/html/templates/immutable_list_mixin.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 9 chunks +18 lines, -0 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 9 chunks +18 lines, -0 lines 0 comments Download
A + tests/corelib/list_first_test.dart View 1 2 1 chunk +9 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
floitsch
8 years, 1 month ago (2012-11-16 20:04:00 UTC) #1
sra1
lgtm Nice!
8 years, 1 month ago (2012-11-16 21:12:22 UTC) #2
floitsch
Added interceptor and test. Compare to Patch set 1. TBR.
8 years, 1 month ago (2012-11-16 21:57:35 UTC) #3
sra1
8 years, 1 month ago (2012-11-16 23:35:35 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698