Issue 11316031: - Move MathNatives from dart:core to dart:math.

Issue 11316031: - Move MathNatives from dart:core to dart:math. (Closed)

Created:
8 years, 1 month ago by Ivan Posva

Modified:
8 years, 1 month ago

Reviewers:
Anders Johnsen, Mads Ager (google), siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Move MathNatives from dart:core to dart:math. - Split out double and integer parsing from MathNatives. Committed: https://code.google.com/p/dart/source/detail?r=15032

Patch Set 2 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+191 lines, -187 lines)			Patch
M	runtime/lib/double.cc	View	1	2 chunks	+56 lines, -0 lines	0 comments	Download
M	runtime/lib/double_patch.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/lib/integers.cc	View	1	2 chunks	+27 lines, -0 lines	0 comments	Download
M	runtime/lib/integers_patch.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/lib/lib_sources.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/lib/math.cc	View		1 chunk	+11 lines, -114 lines	0 comments	Download
D	runtime/lib/math.dart	View		1 chunk	+0 lines, -36 lines	0 comments	Download
M	runtime/lib/math_patch.dart	View		2 chunks	+41 lines, -19 lines	0 comments	Download
M	runtime/lib/math_sources.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View		3 chunks	+13 lines, -13 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/scanner.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/scanner.cc	View	1	1 chunk	+30 lines, -0 lines	0 comments	Download
M	runtime/vm/vm.gypi	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://chromiumcodereview.appspot.com/11316031/diff/1/runtime/lib/integers.cc File runtime/lib/integers.cc (right): https://chromiumcodereview.appspot.com/11316031/diff/1/runtime/lib/integers.cc#newcode195 runtime/lib/integers.cc:195: } else { Is the else needed here? ...

8 years, 1 month ago (2012-11-16 01:34:26 UTC) #2

Mads Ager (google)

LGTM https://chromiumcodereview.appspot.com/11316031/diff/1/runtime/vm/scanner.cc File runtime/vm/scanner.cc (right): https://chromiumcodereview.appspot.com/11316031/diff/1/runtime/vm/scanner.cc#newcode180 runtime/vm/scanner.cc:180: Token::Kind literal_kind, Indentation is slightly off. https://chromiumcodereview.appspot.com/11316031/diff/1/runtime/vm/scanner.cc#newcode192 runtime/vm/scanner.cc:192: ...

8 years, 1 month ago (2012-11-16 05:46:21 UTC) #3

Ivan Posva

8 years, 1 month ago (2012-11-16 19:26:43 UTC) #4

https://chromiumcodereview.appspot.com/11316031/diff/1/runtime/lib/integers.cc
File runtime/lib/integers.cc (right):

https://chromiumcodereview.appspot.com/11316031/diff/1/runtime/lib/integers.c...
runtime/lib/integers.cc:195: } else {
On 2012/11/16 01:34:26, siva wrote:
> Is the else needed here? It could be similar to the way
> it is coded in Double_parse

Done here and in similar places such as line 189 above.

https://chromiumcodereview.appspot.com/11316031/diff/1/runtime/vm/scanner.cc
File runtime/vm/scanner.cc (right):

https://chromiumcodereview.appspot.com/11316031/diff/1/runtime/vm/scanner.cc#...
runtime/vm/scanner.cc:178: // may not be efficient as we need to generate two
extra growable arrays.
On 2012/11/16 01:34:26, siva wrote:
> This comment here does not seem to make sense?

Adjusted comment explaining what this method is for.

https://chromiumcodereview.appspot.com/11316031/diff/1/runtime/vm/scanner.cc#...
runtime/vm/scanner.cc:180: Token::Kind literal_kind,
On 2012/11/16 05:46:21, Mads Ager wrote:
> Indentation is slightly off.

Done.

https://chromiumcodereview.appspot.com/11316031/diff/1/runtime/vm/scanner.cc#...
runtime/vm/scanner.cc:192: (tokens[0].kind == Token::kSUB)) &&
On 2012/11/16 05:46:21, Mads Ager wrote:
> Indentation sligthly off.

Done.

Expand Messages | Collapse Messages