Issue 11316020: Dart generation changes for splitting apart resolvers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11316020: Dart generation changes for splitting apart resolvers. (Closed)

Created:
8 years, 1 month ago by blois

Modified:
8 years, 1 month ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Dart generation changes for splitting apart resolvers. BUG=6722 Committed: https://code.google.com/p/dart/source/detail?r=14991

Patch Set 2 : Dart generation changes for splitting apart resolvers. #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -15 lines)			Patch
	M	sdk/lib/html/scripts/systemnative.py	View	1	4 chunks	+26 lines, -14 lines	0 comments	Download
	M	sdk/lib/html/templates/html/dartium/cpp_resolver.template	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm https://codereview.chromium.org/11316020/diff/1/sdk/lib/html/scripts/systemnative.py File sdk/lib/html/scripts/systemnative.py (right): https://codereview.chromium.org/11316020/diff/1/sdk/lib/html/scripts/systemnative.py#newcode876 sdk/lib/html/scripts/systemnative.py:876: if not library_name in self._library_headers: I am big ...

8 years, 1 month ago (2012-11-15 18:41:17 UTC) #2

blois

8 years, 1 month ago (2012-11-16 00:25:13 UTC) #3

https://codereview.chromium.org/11316020/diff/1/sdk/lib/html/scripts/systemna...
File sdk/lib/html/scripts/systemnative.py (right):

https://codereview.chromium.org/11316020/diff/1/sdk/lib/html/scripts/systemna...
sdk/lib/html/scripts/systemnative.py:876: if not library_name in
self._library_headers:
On 2012/11/15 18:41:17, Anton Muhin wrote:
> I am big fan of self._library_headers.get(library_name, []).append(path) but
it
> might be too esoteric, up to you to decide

I like it!

Expand Messages | Collapse Messages

Issue 11316020: Dart generation changes for splitting apart resolvers. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Dart generation changes for splitting apart resolvers. #

Messages