Issue 1131493007: Compute accurate token count when loading from snapshot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1131493007: Compute accurate token count when loading from snapshot (Closed)

Created:
5 years, 7 months ago by hausner

Modified:
5 years, 7 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Compute accurate token count when loading from snapshot With --compiler-stats, traverse heap at isolate shutdown to find all token streams and compute the number of tokens in the stream. This fixes incorrect token counts when loading from snapshot. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=45806

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -17 lines)			Patch
M	runtime/vm/compiler_stats.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/compiler_stats.cc	View	5 chunks	+48 lines, -3 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

hausner

5 years, 7 months ago (2015-05-15 00:11:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r45806 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages