Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 113143005: Don't try to get dart2js inputs from barback for directories that aren't public. (Closed)

Created:
7 years ago by Bob Nystrom
Modified:
7 years ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't try to get dart2js inputs from barback for directories that aren't public. BUG=https://code.google.com/p/dart/issues/detail?id=15688 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=31313

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -22 lines) Patch
M sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart View 2 chunks +8 lines, -2 lines 0 comments Download
A + sdk/lib/_internal/pub/test/transformer/dart2js/reads_nonpublic_files_from_disk_test.dart View 2 chunks +9 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
7 years ago (2013-12-20 00:39:28 UTC) #1
nweiz
lgtm
7 years ago (2013-12-20 01:20:58 UTC) #2
Bob Nystrom
7 years ago (2013-12-20 01:42:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31313 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698