Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1131383008: Generate the proper error when a constant refers to itself. (Closed)

Created:
5 years, 7 months ago by Paul Berry
Modified:
5 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Generate the proper error when a constant refers to itself. BUG=dartbug.com/23490 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/e2366de610e8f88fb0f78d42c414248c5e4339be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -27 lines) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 1 chunk +7 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/task/driver.dart View 4 chunks +36 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/task/driver_test.dart View 2 chunks +32 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 7 months ago (2015-05-19 19:47:44 UTC) #2
Brian Wilkerson
LGTM
5 years, 7 months ago (2015-05-19 20:34:07 UTC) #3
Paul Berry
5 years, 7 months ago (2015-05-20 02:37:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e2366de610e8f88fb0f78d42c414248c5e4339be (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698