Issue 1131243005: pkg/csslib: use pkg/test and allow latest version of logging pkg

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1131243005: pkg/csslib: use pkg/test and allow latest version of logging pkg (Closed)

Created:
5 years, 7 months ago by kevmoo

Modified:
5 years, 7 months ago

Reviewers:
jakemac, terry

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/csslib@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -111 lines)			Patch
M	pubspec.yaml	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	test/big_1_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/compiler_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/debug_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/declaration_test.dart	View	4 chunks	+7 lines, -6 lines	0 comments	Download
M	test/error_test.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	test/extend_test.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/mixin_test.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/nested_test.dart	View	4 chunks	+6 lines, -5 lines	0 comments	Download
D	test/run.sh	View	1 chunk	+0 lines, -39 lines	0 comments	Download
D	test/run_all.dart	View	1 chunk	+0 lines, -43 lines	0 comments	Download
M	test/selector_test.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	test/testing.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	test/var_test.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/visitor_test.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

kevmoo

5 years, 7 months ago (2015-05-11 19:35:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d84860d25f0161f64d783068d3e449efceeb0734 (presubmit successful).