Issue 11312200: Eradicate CallSiteInliner::next_ssa_temp_index_.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11312200: Eradicate CallSiteInliner::next_ssa_temp_index_. (Closed)

Created:
8 years, 1 month ago by Vyacheslav Egorov (Google)

Modified:
8 years, 1 month ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Eradicate CallSiteInliner::next_ssa_temp_index_. It should always be equal to the max SSA temp index stored on the caller graph itself. Thus it is redundant and dangerous to store it in two places. R=kmillikin@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14827

Patch Set 1 #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -4 lines)			Patch
	M	runtime/vm/flow_graph_inliner.cc	View		4 chunks	+2 lines, -4 lines	0 comments	Download
	A	tests/language/inline_add_constants_to_initial_env.dart	View		1 chunk	+15 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

8 years, 1 month ago (2012-11-13 00:48:29 UTC) #2

LGTM.

https://codereview.chromium.org/11312200/diff/1/tests/language/inline_add_con...
File tests/language/inline_add_constants_to_initial_env.dart (right):

https://codereview.chromium.org/11312200/diff/1/tests/language/inline_add_con...
tests/language/inline_add_constants_to_initial_env.dart:4: // Test that SSA
values are correctly numbered after inlining that adds constants
I guess this is a long line.  Suggest // NOLINT or to wrap it.

Expand Messages | Collapse Messages