Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Issue 11312197: Enforce proper library/import syntax (Closed)

Created:
8 years, 1 month ago by hausner
Modified:
8 years, 1 month ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Enforce proper library/import syntax Committed: https://code.google.com/p/dart/source/detail?r=14828

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M runtime/vm/parser.cc View 1 3 chunks +11 lines, -1 line 0 comments Download
M tests/co19/co19-runtime.status View 1 2 1 chunk +4 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
8 years, 1 month ago (2012-11-13 00:01:00 UTC) #1
siva
lgtm http://codereview.chromium.org/11312197/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): http://codereview.chromium.org/11312197/diff/1/runtime/vm/parser.cc#newcode4491 runtime/vm/parser.cc:4491: } else if (is_library) { isn't this equivalent ...
8 years, 1 month ago (2012-11-13 00:21:53 UTC) #2
hausner
8 years, 1 month ago (2012-11-13 01:07:13 UTC) #3
http://codereview.chromium.org/11312197/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/11312197/diff/1/runtime/vm/parser.cc#newcode4491
runtime/vm/parser.cc:4491: } else if (is_library) {
Keeping as is, as per our offline discussion.

On 2012/11/13 00:21:53, siva wrote:
> isn't this equivalent to
> else if (!is_script) {
> ...
> }
> as you have already asserted that kind is
> !RawScript::kSourceTag
> 
>

Powered by Google App Engine
This is Rietveld 408576698