Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 11312144: Allow function as replacement argument to String.replaceAll. (Closed)

Created:
8 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
8 years, 1 month ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow function as replacement argument to String.replaceAll. TBR=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=14678

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -9 lines) Patch
M runtime/lib/string_base.dart View 1 chunk +18 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/interceptors.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/string_helper.dart View 3 chunks +56 lines, -1 line 0 comments Download
M sdk/lib/core/regexp.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/string.dart View 1 chunk +8 lines, -3 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein Nielsen
Moved from bleeding_edge CL with comments addressed.
8 years, 1 month ago (2012-11-08 12:56:31 UTC) #1
floitsch
8 years, 1 month ago (2012-11-08 13:41:39 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698