Issue 11312105: Do not inline static calls that have not been executed in unoptimized code: the inlined function do…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11312105: Do not inline static calls that have not been executed in unoptimized code: the inlined function do… (Closed)

Created:
8 years, 1 month ago by srdjan

Modified:
8 years, 1 month ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Do not inline static calls that have not been executed in unoptimized code: the inlined function does not have type feedback that takes that call's arguments into account. As a side effect, it fixes a crash in smi-equality. Committed: https://code.google.com/p/dart/source/detail?r=14605

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -10 lines)			Patch
M	runtime/vm/compiler.cc	View	1 2	1 chunk	+6 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_inliner.h	View	1 2	1 chunk	+7 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	1 2	4 chunks	+20 lines, -7 lines	0 comments	Download
M	runtime/vm/object.h	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages