Issue 11312091: Rename DOMURL to ObjectUrl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11312091: Rename DOMURL to ObjectUrl. (Closed)

Created:
8 years, 1 month ago by Emily Fortuna

Modified:
8 years, 1 month ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Rename DOMURL to ObjectUrl. Committed: https://code.google.com/p/dart/source/detail?r=14550

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -148 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		5 chunks	+31 lines, -51 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		5 chunks	+45 lines, -69 lines	0 comments	Download
M	sdk/lib/html/scripts/htmlrenamer.py	View	1 2	2 chunks	+3 lines, -0 lines	0 comments	Download
M	sdk/lib/html/scripts/systemhtml.py	View	1 2 3	2 chunks	+10 lines, -1 line	0 comments	Download
M	sdk/lib/html/templates/html/dart2js/impl_LocalWindow.darttemplate	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	sdk/lib/html/templates/html/dartium/impl_LocalWindow.darttemplate	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	sdk/lib/html/templates/html/interface/interface_LocalWindow.darttemplate	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	tests/html/url_test.dart	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Fix for: http://code.google.com/p/dart/issues/detail?id=5595

8 years, 1 month ago (2012-11-05 20:45:05 UTC) #1

blois

8 years, 1 month ago (2012-11-05 21:41:47 UTC) #2

lgtm

Don't forget to send out a breaking change email!

https://codereview.chromium.org/11312091/diff/1010/sdk/lib/html/dart2js/html_...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/11312091/diff/1010/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:34992: +  factory Url() =>
_UrlFactoryProvider.createUrl();
Can we omit the constructor? I don't think it means anything (if it even works).

Expand Messages | Collapse Messages