Issue 11312081: Issue 6251. Resolve and rename [id] references in documentation comments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11312081: Issue 6251. Resolve and rename [id] references in documentation comments (Closed)

Created:
8 years, 1 month ago by scheglov

Modified:
8 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 6251. Resolve and rename [id] references in documentation comments http://code.google.com/p/dart/issues/detail?id=6251 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14538

Patch Set 1 #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+308 lines, -36 lines)			Patch
M	compiler/java/com/google/dart/compiler/ast/DartComment.java	View	2 chunks	+10 lines, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/DartDeclaration.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/DartUnit.java	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/DartParserCommentsHelper.java	View	4 chunks	+40 lines, -2 lines	2 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/Resolver.java	View	5 chunks	+17 lines, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	2 chunks	+79 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java	View	12 chunks	+26 lines, -31 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/utilities/ast/DartElementLocatorTest.java	View	1 chunk	+61 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/SemanticHighlightingReconciler.java	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RenameLocalVariableProcessorTest.java	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RenameMethodProcessorTest.java	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RenameTypeProcessorTest.java	View	1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years, 1 month ago (2012-11-05 16:07:12 UTC) #2

LGTM as a first step

https://codereview.chromium.org/11312081/diff/1/compiler/java/com/google/dart...
File compiler/java/com/google/dart/compiler/parser/DartParserCommentsHelper.java
(right):

https://codereview.chromium.org/11312081/diff/1/compiler/java/com/google/dart...
compiler/java/com/google/dart/compiler/parser/DartParserCommentsHelper.java:185:
if (tokenSrc.startsWith(":") && tokenSrc.endsWith(":")) {
You might also want to explicitly test for quote characters (for a string
literal).

https://codereview.chromium.org/11312081/diff/1/compiler/java/com/google/dart...
compiler/java/com/google/dart/compiler/parser/DartParserCommentsHelper.java:186:
} else if (tokenSrc.startsWith("new ")) {
Perhaps add a TODO comment here, unless you're planning on tackling this in the
next CL.

Expand Messages | Collapse Messages