Remove references to ObjectNotClosureException and ClosureArgumentMismatchException

Remove references to ObjectNotClosureException and ClosureArgumentMismatchException
from the VM (issue 6124).
These are replaced with NoSuchMethodError for now (work in progress).
Committed: https://code.google.com/p/dart/source/detail?r=14362

[srdjan, 2012-10-31 17:52:51]

LGTM

https://codereview.chromium.org/11312019/diff/1/runtime/lib/object.cc
File runtime/lib/object.cc (right):

https://codereview.chromium.org/11312019/diff/1/runtime/lib/object.cc#newcode28
runtime/lib/object.cc:28: // TODO(regis): Change to Exceptions::kNoSuchMethod.
Remove the TODO since this has not been agreed upon.

https://codereview.chromium.org/11312019/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/11312019/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1193: 
Please add a comment saying that the object is not a closure and that we are
throwing an exception.

https://codereview.chromium.org/11312019/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1199: GrowableArray<const Object*> dart_arguments;
dart_arguments(4);

https://codereview.chromium.org/11312019/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1203: const Object& null_object =
Object::Handle(Object::null());
Why not just Object::Handle();?

https://codereview.chromium.org/11312019/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1209: // Report if a function with same name (but
different arguments) has been
Maybe adapt argument that we are not looking at any function, but specifically
at  function named 'call'.

https://codereview.chromium.org/11312019/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1385: // TODO(regis): Change to
Exceptions::kNoSuchMethod.
Remove TODO

https://codereview.chromium.org/11312019/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1399: // found.
ditto 'a function with ...' -> 'function named "call" .." or similar

https://codereview.chromium.org/11312019/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1432: const Object& null_object =
Object::Handle(Object::null());
Why not Object::Handle(); ?

[regis, 2012-10-31 18:04:37]

Thanks!

https://codereview.chromium.org/11312019/diff/1/runtime/lib/object.cc
File runtime/lib/object.cc (right):

https://codereview.chromium.org/11312019/diff/1/runtime/lib/object.cc#newcode28
runtime/lib/object.cc:28: // TODO(regis): Change to Exceptions::kNoSuchMethod.
On 2012/10/31 17:52:51, srdjan wrote:
> Remove the TODO since this has not been agreed upon.

Done.

https://codereview.chromium.org/11312019/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/11312019/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1193: 
On 2012/10/31 17:52:51, srdjan wrote:
> Please add a comment saying that the object is not a closure and that we are
> throwing an exception.

Added:
  // The result instance is not a closure, try to invoke method "call" before
  // throwing a NoSuchMethodError.

https://codereview.chromium.org/11312019/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1199: GrowableArray<const Object*> dart_arguments;
On 2012/10/31 17:52:51, srdjan wrote:
> dart_arguments(4);

Done (5).

https://codereview.chromium.org/11312019/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1203: const Object& null_object =
Object::Handle(Object::null());
On 2012/10/31 17:52:51, srdjan wrote:
> Why not just Object::Handle();?

Done.

https://codereview.chromium.org/11312019/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1209: // Report if a function with same name (but
different arguments) has been
On 2012/10/31 17:52:51, srdjan wrote:
> Maybe adapt argument that we are not looking at any function, but specifically
> at  function named 'call'.

Done.

https://codereview.chromium.org/11312019/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1385: // TODO(regis): Change to
Exceptions::kNoSuchMethod.
On 2012/10/31 17:52:51, srdjan wrote:
> Remove TODO

Done.

https://codereview.chromium.org/11312019/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1399: // found.
On 2012/10/31 17:52:51, srdjan wrote:
> ditto 'a function with ...' -> 'function named "call" .." or similar 

Done.

https://codereview.chromium.org/11312019/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1432: const Object& null_object =
Object::Handle(Object::null());
On 2012/10/31 17:52:51, srdjan wrote:
> Why not Object::Handle(); ?

Done.