Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 11312007: remove text editor plugins, they are now on github (Closed)

Created:
8 years, 1 month ago by sethladd
Modified:
8 years, 1 month ago
Reviewers:
dgrove, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

remove text editor plugins, they are now on github BUG= Committed: https://code.google.com/p/dart/source/detail?r=14231

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -964 lines) Patch
D tools/utils/elisp/dart-mode.el View 1 chunk +0 lines, -169 lines 0 comments Download
D tools/utils/textmate/Dart.tmbundle/Preferences/Comments.tmPreferences View 1 chunk +0 lines, -36 lines 0 comments Download
D tools/utils/textmate/Dart.tmbundle/Syntaxes/Dart.textmate View 1 chunk +0 lines, -184 lines 0 comments Download
D tools/utils/textmate/Dart.tmbundle/Syntaxes/Dart.tmLanguage View 1 chunk +0 lines, -417 lines 0 comments Download
D tools/utils/textmate/Dart.tmbundle/info.plist View 1 chunk +0 lines, -10 lines 0 comments Download
D tools/utils/textmate/README View 1 chunk +0 lines, -20 lines 0 comments Download
D tools/utils/vim/syntax/dart.vim View 1 chunk +0 lines, -128 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sethladd
Now on: https://github.com/dart-lang/text-editor-plugins-for-dart
8 years, 1 month ago (2012-10-29 23:10:40 UTC) #1
dgrove
lgtm
8 years, 1 month ago (2012-10-29 23:12:26 UTC) #2
ahe
8 years, 1 month ago (2012-10-31 15:55:31 UTC) #3
I have reverted this CL (https://codereview.chromium.org/11364007/). Next time
you decide to move something to github, please make sure to meet these two
requirements:

1. Ask the rest of the team if they agree.

2. Announce the change to Dart *developers*.

I'm actually using dart-mode.el, and so are my co-workers. We have more
important stuff to do than guessing where to find a file that you deleted with
no prior warning.

Powered by Google App Engine
This is Rietveld 408576698