Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1131063004: Remove unused InternalAnalysisContext.addSourceInfo(). (Closed)

Created:
5 years, 7 months ago by scheglov
Modified:
5 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Remove unused InternalAnalysisContext.addSourceInfo(). The analysis cache is now accessible, if we will ever need this feature again. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45616

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 2 chunks +0 lines, -13 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 7 months ago (2015-05-07 19:50:30 UTC) #1
Brian Wilkerson
LGTM
5 years, 7 months ago (2015-05-07 20:01:23 UTC) #2
scheglov
5 years, 7 months ago (2015-05-07 20:17:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45616 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698