Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 1131053002: Don't update offsets for elements of 'part' and 'part of' directives. (Closed)

Created:
5 years, 7 months ago by scheglov
Modified:
5 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Don't update offsets for elements of 'part' and 'part of' directives. These elements are not defined in the source that references it. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45605

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
M pkg/analyzer/lib/src/task/incremental_element_builder.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/incremental_element_builder_test.dart View 2 chunks +32 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 7 months ago (2015-05-07 17:57:10 UTC) #1
Brian Wilkerson
LGTM
5 years, 7 months ago (2015-05-07 18:17:48 UTC) #2
scheglov
5 years, 7 months ago (2015-05-07 18:34:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45605 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698