Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1130963002: FIxed 'typo', enabled lazy var descriptors generation again. (Closed)

Created:
5 years, 7 months ago by srdjan
Modified:
5 years, 7 months ago
Reviewers:
hausner, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

FIxed 'typo', enabled lazy var descriptors generation again. Committed: https://code.google.com/p/dart/source/detail?r=45583

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/flow_graph_compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 7 (2 generated)
srdjan
TBR
5 years, 7 months ago (2015-05-07 04:47:25 UTC) #2
srdjan
Committed patchset #1 (id:1) manually as r45583 (presubmit successful).
5 years, 7 months ago (2015-05-07 05:34:55 UTC) #3
hausner
lgtm
5 years, 7 months ago (2015-05-07 15:40:14 UTC) #4
Ivan Posva
DBC -ip https://codereview.chromium.org/1130963002/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1130963002/diff/1/runtime/vm/object.cc#newcode12051 runtime/vm/object.cc:12051: LocalVarDescriptors& v = LocalVarDescriptors::Handle(var_descriptors()); const LocalVarDescriptors
5 years, 7 months ago (2015-05-07 17:54:59 UTC) #6
srdjan
5 years, 7 months ago (2015-05-07 18:20:24 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1130963002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1130963002/diff/1/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:12051: LocalVarDescriptors& v =
LocalVarDescriptors::Handle(var_descriptors());
On 2015/05/07 17:54:59, Ivan Posva wrote:
> const LocalVarDescriptors

Done in a next CL.

Powered by Google App Engine
This is Rietveld 408576698