Issue 11308346: Disabling snapshots on windows for dartdoc and dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11308346: Disabling snapshots on windows for dartdoc and dart2js. (Closed)

Created:
8 years ago by devoncarew

Modified:
8 years ago

Reviewers:
dgrove, ahe

CC:
reviews_dartlang.org, aam-me

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Disabling snapshots on windows for dartdoc and dart2js. When run, we get the error message: \dart\dart-sdk\bin\dart2js.snapshot was unexpected at this time. Committed: https://code.google.com/p/dart/source/detail?r=15693

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	sdk/bin/dart2js.bat	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	sdk/bin/dartdoc.bat	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

Did you file a bug on this? https://codereview.chromium.org/11308346/diff/1/sdk/bin/dart2js.bat File sdk/bin/dart2js.bat (right): https://codereview.chromium.org/11308346/diff/1/sdk/bin/dart2js.bat#newcode15 sdk/bin/dart2js.bat:15: "%SCRIPTPATH%dart" --no_use_inlining ...

8 years ago (2012-12-04 15:13:53 UTC) #2

ahe

https://codereview.chromium.org/11308346/diff/2002/sdk/bin/dartdoc.bat File sdk/bin/dartdoc.bat (right): https://codereview.chromium.org/11308346/diff/2002/sdk/bin/dartdoc.bat#newcode12 sdk/bin/dartdoc.bat:12: set SNAPSHOTNAME="%SCRIPTPATH%dartdoc.snapshot" Good catch!

8 years ago (2012-12-04 15:30:08 UTC) #3

LGTM and thank you!

Expand Messages | Collapse Messages