Issue 11308298: Restrict the set of files that will be pub lished.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11308298: Restrict the set of files that will be pub lished. (Closed)

Created:
8 years ago by nweiz

Modified:
8 years ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Restrict the set of files that will be pub lished. This ensures that hidden directories, packages directories, and pubspec.lock files aren't pub lished. BUG=7001 Committed: https://code.google.com/p/dart/source/detail?r=15602

Patch Set 1 #

Total comments: 2

Created: 8 years ago

		Unified diffs	Side-by-side diffs	Stats (+47 lines, -16 lines)
	M	utils/pub/command_lish.dart	View	2 chunks	+11 lines, -1 line	0 comments
	M	utils/pub/io.dart	View	6 chunks	+36 lines, -15 lines	2 comments

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM. https://codereview.chromium.org/11308298/diff/1/utils/pub/io.dart File utils/pub/io.dart (right): https://codereview.chromium.org/11308298/diff/1/utils/pub/io.dart#newcode65 utils/pub/io.dart:65: List<String> splitPath(path) => _sanitizePath(path).split('/'); Doc comment.

8 years ago (2012-11-30 21:31:59 UTC) #2

nweiz

8 years ago (2012-11-30 21:37:45 UTC) #3

https://codereview.chromium.org/11308298/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://codereview.chromium.org/11308298/diff/1/utils/pub/io.dart#newcode65
utils/pub/io.dart:65: List<String> splitPath(path) =>
_sanitizePath(path).split('/');
On 2012/11/30 21:31:59, Bob Nystrom wrote:
> Doc comment.

Done.

Expand Messages | Collapse Messages