Issue 11308293: Fix test.dart's --build-directory option to accept absolute paths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11308293: Fix test.dart's --build-directory option to accept absolute paths. (Closed)

Created:
8 years ago by Bill Hesse

Modified:
8 years ago

Reviewers:
ahe, kustermann

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix test.dart's --build-directory option to accept absolute paths. BUG= Committed: https://code.google.com/p/dart/source/detail?r=15632

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -9 lines)			Patch
	M	tools/testing/dart/test_suite.dart	View		1 chunk	+8 lines, -9 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

Really, all uses of buildDir should take a Path, and they should know at each ...

8 years ago (2012-11-30 18:51:11 UTC) #1

ahe

8 years ago (2012-12-03 11:42:39 UTC) #3

LGTM

https://codereview.chromium.org/11308293/diff/1/tools/testing/dart/test_suite...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11308293/diff/1/tools/testing/dart/test_suite...
tools/testing/dart/test_suite.dart:1031: Path generatedTestPath = new
Path.fromNative(buildDir)
Nice.

Expand Messages | Collapse Messages