Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 11308281: Preserve the stack trace for rethrown exceptions in Future.transformException. (Closed)

Created:
8 years ago by nweiz
Modified:
8 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Preserve the stack trace for rethrown exceptions in Future.transformException. Committed: https://code.google.com/p/dart/source/detail?r=15704

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M sdk/lib/core/future_impl.dart View 1 chunk +5 lines, -1 line 0 comments Download
M tests/corelib/future_test.dart View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
8 years ago (2012-11-29 20:39:09 UTC) #1
Siggi Cherem (dart-lang)
lgtm!
8 years ago (2012-11-29 21:16:51 UTC) #2
floitsch
8 years ago (2012-12-03 22:52:02 UTC) #3
in lib_v2 we are going to change this to an AsyncError, but the change LGTM.
In the worst case we will change it, but even then it will look similar.

Powered by Google App Engine
This is Rietveld 408576698