Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 11308279: Fix curl path-munging in create_sdk.py. (Closed)

Created:
8 years ago by Bob Nystrom
Modified:
8 years ago
Reviewers:
nweiz, dgrove
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix curl path-munging in create_sdk.py. The string literals in the Dart code are using " not ', so the patterns didn't match. :( BUG= Committed: https://code.google.com/p/dart/source/detail?r=15534

Patch Set 1 #

Patch Set 2 : Do same munging style for 7zip. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M tools/create_sdk.py View 1 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
8 years ago (2012-11-29 18:57:10 UTC) #1
nweiz
LGTM You should probably do this for 7zip as well.
8 years ago (2012-11-29 18:59:03 UTC) #2
Bob Nystrom
8 years ago (2012-11-29 19:01:42 UTC) #3
On 2012/11/29 18:59:03, nweiz wrote:
> LGTM
> 
> You should probably do this for 7zip as well.

Done.

Powered by Google App Engine
This is Rietveld 408576698