Fix problems due to unit testing of the compiler.

Fix problems due to unit testing of the compiler.
Committed: https://code.google.com/p/dart/source/detail?r=15400

[ngeoffray, 2012-11-27 16:33:10]

TBR to unbreak the builds.

[ahe, 2012-11-28 11:17:36]

LGTM, but perhaps reconsider if it would be better to turn missing interceptor
classes into internal errors.

https://codereview.chromium.org/11308227/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/11308227/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:785: if (cls
!= null) interceptedClasses[cls] = null;
Shouldn't we make this an internal error instead?

https://codereview.chromium.org/11308227/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/11308227/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1716: if
(backend.objectInterceptorClass == null) return;
I would think it was an internal error if backend.objectInterceptorClass is
null.

https://codereview.chromium.org/11308227/diff/1/tests/utils/dummy_compiler_te...
File tests/utils/dummy_compiler_test.dart (right):

https://codereview.chromium.org/11308227/diff/1/tests/utils/dummy_compiler_te...
tests/utils/dummy_compiler_test.dart:37: } else if
(uri.path.endsWith('interceptors.dart')) {
Should be '/interceptors.dart', I think.

[ngeoffray, 2012-11-28 11:42:03]

Thanks Peter

https://codereview.chromium.org/11308227/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/11308227/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1716: if
(backend.objectInterceptorClass == null) return;
On 2012/11/28 11:17:36, ahe wrote:
> I would think it was an internal error if backend.objectInterceptorClass is
> null.

Not in case there is no class being instantiated. Right now there is always one
because we analyze all of js_helper.

https://codereview.chromium.org/11308227/diff/1/tests/utils/dummy_compiler_te...
File tests/utils/dummy_compiler_test.dart (right):

https://codereview.chromium.org/11308227/diff/1/tests/utils/dummy_compiler_te...
tests/utils/dummy_compiler_test.dart:37: } else if
(uri.path.endsWith('interceptors.dart')) {
On 2012/11/28 11:17:36, ahe wrote:
> Should be '/interceptors.dart', I think.

The other uri.path checks don't use '/'. Why would you use it here?

[ahe, 2012-11-28 12:26:21]

https://codereview.chromium.org/11308227/diff/1/tests/utils/dummy_compiler_te...
File tests/utils/dummy_compiler_test.dart (right):

https://codereview.chromium.org/11308227/diff/1/tests/utils/dummy_compiler_te...
tests/utils/dummy_compiler_test.dart:37: } else if
(uri.path.endsWith('interceptors.dart')) {
On 2012/11/28 11:42:03, ngeoffray wrote:
> On 2012/11/28 11:17:36, ahe wrote:
> > Should be '/interceptors.dart', I think.
> 
> The other uri.path checks don't use '/'. Why would you use it here?

The one on line 35 doesn't because it is matching this shell filename wildcard:
*_patch.dart

The one on line 16 is matching the complete filename, so it includes the slash.