Issue 11308206: Cleaning up some unused code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11308206: Cleaning up some unused code. (Closed)

Created:
8 years ago by blois

Modified:
8 years ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cleaning up some unused code. Just removing an template file which is no longer being used and a class which is not being used either. BUG= Committed: https://code.google.com/p/dart/source/detail?r=15362

Patch Set 1 #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -66 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	2 chunks	+1 line, -19 lines	2 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	2 chunks	+1 line, -19 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_Element.darttemplate	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	sdk/lib/html/templates/interface.darttemplate	View	1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

lgtm, with one question https://codereview.chromium.org/11308206/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/11308206/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode22052 sdk/lib/html/dart2js/html_dart2js.dart:22052: * Wrapper to expose [Element.attributes] ...

8 years ago (2012-11-26 22:16:26 UTC) #2

blois

8 years ago (2012-11-27 01:02:03 UTC) #3

https://codereview.chromium.org/11308206/diff/1/sdk/lib/html/dart2js/html_dar...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/11308206/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:22052: * Wrapper to expose
[Element.attributes] as a typed map.
On 2012/11/26 22:16:26, Emily Fortuna wrote:
> why take out the [] link here?

Adding it in- was from an earlier CL that I forgot to run go.sh after updating.

Expand Messages | Collapse Messages