Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 11308179: Add --build-directory option to test.py. (Closed)

Created:
8 years, 1 month ago by Bill Hesse
Modified:
8 years, 1 month ago
Reviewers:
ahe, kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add --build-directory option to test.py. Fix problem when no --step-name option is present. BUG=dart:6885 Committed: https://code.google.com/p/dart/source/detail?r=15280

Patch Set 1 #

Patch Set 2 : Use build_directory option instead, fix step_name behavior when no step name present. #

Patch Set 3 : Fix test_runner_exit_code_script.dart to set a buildbot step name. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -16 lines) Patch
M tests/standalone/io/test_runner_exit_code_script.dart View 1 2 1 chunk +3 lines, -0 lines 1 comment Download
M tools/testing/dart/test_options.dart View 1 2 chunks +7 lines, -1 line 0 comments Download
M tools/testing/dart/test_progress.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_suite.dart View 1 3 chunks +16 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bill Hesse
I think this is better than specifying the build directory explicitly.
8 years, 1 month ago (2012-11-23 10:38:55 UTC) #1
ahe
On 2012/11/23 10:38:55, Bill Hesse wrote: > I think this is better than specifying the ...
8 years, 1 month ago (2012-11-23 11:36:39 UTC) #2
ahe
Thank you, Bill! LGTM
8 years, 1 month ago (2012-11-23 12:28:34 UTC) #3
Bill Hesse
https://codereview.chromium.org/11308179/diff/5001/tests/standalone/io/test_runner_exit_code_script.dart File tests/standalone/io/test_runner_exit_code_script.dart (right): https://codereview.chromium.org/11308179/diff/5001/tests/standalone/io/test_runner_exit_code_script.dart#newcode16 tests/standalone/io/test_runner_exit_code_script.dart:16: new ProgressIndicator.fromName(progressType, startTime, false); Added so that the test ...
8 years, 1 month ago (2012-11-23 12:53:38 UTC) #4
kustermann
8 years, 1 month ago (2012-11-23 13:14:16 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698