Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issue 11308166: Fix bug 6467: (Closed)

Created:
8 years, 1 month ago by Ivan Posva
Modified:
8 years ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix bug 6467: - Do not attempt to Dart_ExitScope if no scope exists. - Print more informative message if Dart_Initialization fails. Committed: https://code.google.com/p/dart/source/detail?r=15242

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -11 lines) Patch
M runtime/bin/main.cc View 2 chunks +4 lines, -1 line 0 comments Download
M runtime/bin/run_vm_tests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/dart.h View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/dart.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Ivan Posva
TBR
8 years, 1 month ago (2012-11-22 07:53:34 UTC) #1
siva
8 years ago (2012-11-26 16:42:55 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698