Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 11308111: Refactor http.Client and http.BaseClient to allow http.Client in type annotations. (Closed)

Created:
8 years, 1 month ago by nweiz
Modified:
8 years, 1 month ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Refactor http.Client and http.BaseClient to allow http.Client in type annotations. Committed: https://code.google.com/p/dart/source/detail?r=15124

Patch Set 1 #

Patch Set 2 : Small fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -83 lines) Patch
M pkg/http/lib/http.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M pkg/http/lib/src/base_client.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/http/lib/src/client.dart View 1 1 chunk +71 lines, -57 lines 0 comments Download
A + pkg/http/lib/src/io_client.dart View 2 chunks +4 lines, -12 lines 0 comments Download
M pkg/oauth2/lib/src/authorization_code_grant.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/oauth2/lib/src/client.dart View 3 chunks +4 lines, -5 lines 0 comments Download
M pkg/oauth2/lib/src/credentials.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
nweiz
8 years, 1 month ago (2012-11-19 23:12:01 UTC) #1
Bob Nystrom
8 years, 1 month ago (2012-11-19 23:37:47 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698