Issue 11308091: Add TypeImpl.hashCode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11308091: Add TypeImpl.hashCode. (Closed)

Created:
8 years, 1 month ago by karlklose

Modified:
8 years, 1 month ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add TypeImpl.hashCode. BUG=http://code.google.com/p/dart/issues/detail?id=6785 Committed: https://code.google.com/p/dart/source/detail?r=15140

Patch Set 1 #

Patch Set 2 : Moved the test to dart2js_extra. #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -0 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/lib/js_helper.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
	A	tests/compiler/dart2js_extra/first_class_types_hashcode_test.dart	View	1	1 chunk	+22 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

karlklose

FYI: I moved the test to dart2js_extra, because the specification does not require this behavior.

8 years, 1 month ago (2012-11-19 15:16:15 UTC) #3

ngeoffray

8 years, 1 month ago (2012-11-19 15:40:32 UTC) #4

http://codereview.chromium.org/11308091/diff/3001/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/first_class_types_hashcode_test.dart (right):

http://codereview.chromium.org/11308091/diff/3001/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/first_class_types_hashcode_test.dart:5: // Check
that Type instances work with maps.
Please add the comment that it assumes canonicalization of types and that is not
specified.

Expand Messages | Collapse Messages