Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 11308087: Added "/// @docsEditable" to all generated members in the HTML lib. (Closed)

Created:
8 years, 1 month ago by Andrei Mouravski
Modified:
8 years, 1 month ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Added "// @editable" to all generated members in the HTML lib. This is included as a way to find exacly the members that will have docs injected after the fact. The members without @editable are expected to be documented inline, wherever the source or template is defined. Committed: https://code.google.com/p/dart/source/detail?r=15179

Patch Set 1 #

Patch Set 2 : Fixed minor issue. #

Patch Set 3 : Removed the thing we're not using.' #

Patch Set 4 : Removed thing #

Patch Set 5 : Back to correct stuff. #

Patch Set 6 : Forgot a thing. #

Total comments: 1

Patch Set 7 : Test upload. #

Patch Set 8 : Testing #

Patch Set 9 : Fixed tags.' #

Patch Set 10 : Removed whitespace. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3949 lines, -3946 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 3 4 5 6 7 8 9 513 chunks +2744 lines, -2744 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 40 chunks +59 lines, -59 lines 0 comments Download
M sdk/lib/html/scripts/htmldartgenerator.py View 1 2 3 4 5 6 7 8 2 chunks +6 lines, -3 lines 1 comment Download
M sdk/lib/html/templates/dart2js_impl.darttemplate View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 2 3 4 5 6 7 8 9 173 chunks +1138 lines, -1138 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Andrei Mouravski
Ahoy. Here's my first pass at getting a hook into the HTML library where I ...
8 years, 1 month ago (2012-11-18 23:22:46 UTC) #1
blois
On 2012/11/18 23:22:46, Andrei Mouravski wrote: > Ahoy. > > Here's my first pass at ...
8 years, 1 month ago (2012-11-19 17:25:46 UTC) #2
Andrei Mouravski
Okay, see if this is good.
8 years, 1 month ago (2012-11-19 22:19:59 UTC) #3
blois
lgtm Looks good, but can you make sure that this doesn't break the MDN generation ...
8 years, 1 month ago (2012-11-19 23:19:06 UTC) #4
Andrei Mouravski
Okay, I was doing the wrong thing with tags, and MDN docs were not showing ...
8 years, 1 month ago (2012-11-20 20:54:20 UTC) #5
blois
https://codereview.chromium.org/11308087/diff/13001/sdk/lib/html/scripts/htmldartgenerator.py File sdk/lib/html/scripts/htmldartgenerator.py (right): https://codereview.chromium.org/11308087/diff/13001/sdk/lib/html/scripts/htmldartgenerator.py#newcode43 sdk/lib/html/scripts/htmldartgenerator.py:43: self._members_emitter.Emit('\n /** @domName $DOMINTERFACE.$DOMNAME;' Semi-colon delimiter? Aren't these normally ...
8 years, 1 month ago (2012-11-20 21:01:53 UTC) #6
blois
8 years, 1 month ago (2012-11-20 21:03:39 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698