Add custom annotations to some APIs for native tree shaking.

Add custom annotations to some APIs for native tree shaking.

Committed: https://code.google.com/p/dart/source/detail?r=15121

[blois, 2012-11-19 20:46:48]

https://codereview.chromium.org/11308075/diff/1006/sdk/lib/html/scripts/gener...
File sdk/lib/html/scripts/generator.py (right):

https://codereview.chromium.org/11308075/diff/1006/sdk/lib/html/scripts/gener...
sdk/lib/html/scripts/generator.py:555: # results, we mark the result as git
instantiating any classes, and mark
git?

https://codereview.chromium.org/11308075/diff/1006/sdk/lib/html/scripts/syste...
File sdk/lib/html/scripts/systemhtml.py (right):

https://codereview.chromium.org/11308075/diff/1006/sdk/lib/html/scripts/syste...
sdk/lib/html/scripts/systemhtml.py:545: print '** ',attr.type.id,
self._DartType(attr.type.id)
Debugging?

https://codereview.chromium.org/11308075/diff/1006/sdk/lib/html/src/dart2js_C...
File sdk/lib/html/src/dart2js_Conversions.dart (right):

https://codereview.chromium.org/11308075/diff/1006/sdk/lib/html/src/dart2js_C...
sdk/lib/html/src/dart2js_Conversions.dart:445: const
annotation_Creates_SerializedScriptValue =
Move these to the top since they are public?

Do they need to be public? If so, add some documentation as well?

https://codereview.chromium.org/11308075/diff/1006/sdk/lib/html/templates/htm...
File sdk/lib/html/templates/html/impl/impl_DocumentFragment.darttemplate
(right):

https://codereview.chromium.org/11308075/diff/1006/sdk/lib/html/templates/htm...
sdk/lib/html/templates/html/impl/impl_DocumentFragment.darttemplate:34:
@Creates('Null')
Why is @Creates('Null') not the default behavior?

[sra1, 2012-11-19 23:15:07]

https://codereview.chromium.org/11308075/diff/1006/sdk/lib/html/scripts/gener...
File sdk/lib/html/scripts/generator.py (right):

https://codereview.chromium.org/11308075/diff/1006/sdk/lib/html/scripts/gener...
sdk/lib/html/scripts/generator.py:555: # results, we mark the result as git
instantiating any classes, and mark
On 2012/11/19 20:46:48, blois wrote:
> git?

Done.

https://codereview.chromium.org/11308075/diff/1006/sdk/lib/html/scripts/syste...
File sdk/lib/html/scripts/systemhtml.py (right):

https://codereview.chromium.org/11308075/diff/1006/sdk/lib/html/scripts/syste...
sdk/lib/html/scripts/systemhtml.py:545: print '** ',attr.type.id,
self._DartType(attr.type.id)
On 2012/11/19 20:46:48, blois wrote:
> Debugging?

Done.

https://codereview.chromium.org/11308075/diff/1006/sdk/lib/html/src/dart2js_C...
File sdk/lib/html/src/dart2js_Conversions.dart (right):

https://codereview.chromium.org/11308075/diff/1006/sdk/lib/html/src/dart2js_C...
sdk/lib/html/src/dart2js_Conversions.dart:445: const
annotation_Creates_SerializedScriptValue =
On 2012/11/19 20:46:48, blois wrote:
> Move these to the top since they are public?
> 
> Do they need to be public? If so, add some documentation as well?

I'm expecting that they will be moved to some common library imported by
dart:html and dart:indexeddb or whatever.

I can make them library-private for now.

https://codereview.chromium.org/11308075/diff/1006/sdk/lib/html/templates/htm...
File sdk/lib/html/templates/html/impl/impl_DocumentFragment.darttemplate
(right):

https://codereview.chromium.org/11308075/diff/1006/sdk/lib/html/templates/htm...
sdk/lib/html/templates/html/impl/impl_DocumentFragment.darttemplate:34:
@Creates('Null')
On 2012/11/19 20:46:48, blois wrote:
> Why is @Creates('Null') not the default behavior?

The default behaviour is @Creates(the-return/field-type)

Otherwise all fields and all methods need annotating.

[blois, 2012-11-19 23:16:47]

lgtm