Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1130763003: Get computeError working (Closed)

Created:
5 years, 7 months ago by Brian Wilkerson
Modified:
5 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+515 lines, -36 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +20 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 1 chunk +12 lines, -0 lines 2 comments Download
M pkg/analyzer/lib/src/plugin/engine_plugin.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 17 chunks +259 lines, -19 lines 4 comments Download
M pkg/analyzer/lib/task/dart.dart View 1 chunk +4 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 5 chunks +8 lines, -9 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 3 chunks +209 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
5 years, 7 months ago (2015-05-07 17:55:57 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1130763003/diff/1/pkg/analyzer/lib/src/generated/error.dart File pkg/analyzer/lib/src/generated/error.dart (right): https://codereview.chromium.org/1130763003/diff/1/pkg/analyzer/lib/src/generated/error.dart#newcode204 pkg/analyzer/lib/src/generated/error.dart:204: return errors; It could be also implemented as: ...
5 years, 7 months ago (2015-05-07 18:11:39 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/1130763003/diff/1/pkg/analyzer/lib/src/generated/error.dart File pkg/analyzer/lib/src/generated/error.dart (right): https://codereview.chromium.org/1130763003/diff/1/pkg/analyzer/lib/src/generated/error.dart#newcode204 pkg/analyzer/lib/src/generated/error.dart:204: return errors; > No type safety though :-( I ...
5 years, 7 months ago (2015-05-07 18:30:08 UTC) #4
Brian Wilkerson
5 years, 7 months ago (2015-05-07 18:30:53 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 45604 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698