Issue 11305007: Getter with parameters is error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11305007: Getter with parameters is error. (Closed)

Created:
8 years, 1 month ago by scheglov

Modified:
8 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Getter with parameters is error. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14161

Patch Set 1 #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+527 lines, -476 lines)			Patch
M	compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java	View	3 chunks	+8 lines, -6 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	2 chunks	+9 lines, -4 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/Elements.java	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java	View	3 chunks	+7 lines, -3 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java	View	10 chunks	+12 lines, -12 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/ResolverCompilerTest.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	27 chunks	+36 lines, -36 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/search/SearchEngineTest.java	View	6 chunks	+140 lines, -140 lines	2 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/utilities/ast/DartElementLocatorTest.java	View	7 chunks	+13 lines, -13 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/utilities/ast/DynamicTypesFinderTest.java	View	3 chunks	+37 lines, -37 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/ExtractLocalRefactoringTest.java	View	4 chunks	+52 lines, -52 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/ExtractUtilsTest.java	View	3 chunks	+100 lines, -100 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RenameFunctionProcessorTest.java	View	3 chunks	+29 lines, -29 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RenameMethodProcessorTest.java	View	4 chunks	+33 lines, -33 lines	0 comments	Download
M	tests/co19/co19-compiler.status	View	4 chunks	+39 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years, 1 month ago (2012-10-26 17:11:53 UTC) #2

LGTM, other than the re-ordering of imports and declarations

https://codereview.chromium.org/11305007/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/search/SearchEngineTest.java
(right):

https://codereview.chromium.org/11305007/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/search/SearchEngineTest.java:16:
import static org.fest.assertions.Assertions.assertThat;
nit: why did these imports move?

https://codereview.chromium.org/11305007/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/search/SearchEngineTest.java:96:
private void assertHasReferenceWithPrefix(List<SearchMatch> references, String
expectedPrefix) {
nit: Why did all of these private methods move? They should be sorted to the end
of the file like they were before. Not something that needs fixed immediately,
but you should check your settings.

Expand Messages | Collapse Messages