Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1130453003: Update {,Linked}Hash{Set,Map} documentation. (Closed)

Created:
5 years, 7 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 7 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Update {,Linked}Hash{Set,Map} documentation. Now specifies that the default [isValidKey] accepts all values in the default and identity cases. BUG= http://dartbug.com/23356 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=45552

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -35 lines) Patch
M sdk/lib/collection/hash_map.dart View 2 chunks +22 lines, -4 lines 0 comments Download
M sdk/lib/collection/hash_set.dart View 2 chunks +32 lines, -11 lines 0 comments Download
M sdk/lib/collection/linked_hash_map.dart View 2 chunks +24 lines, -6 lines 0 comments Download
M sdk/lib/collection/linked_hash_set.dart View 1 chunk +37 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lasse Reichstein Nielsen
5 years, 7 months ago (2015-05-05 12:40:55 UTC) #2
Søren Gjesse
LGTM!
5 years, 7 months ago (2015-05-05 16:40:45 UTC) #3
Lasse Reichstein Nielsen
5 years, 7 months ago (2015-05-06 08:35:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45552 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698