Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 11304007: Move SplayTreeMap from coreimpl to collection. (Closed)

Created:
8 years, 1 month ago by Anders Johnsen
Modified:
8 years, 1 month ago
CC:
reviews_dartlang.org, Mads Ager (google), Lasse Reichstein Nielsen
Visibility:
Public.

Description

Move SplayTreeMap from coreimpl to collection. BUG= Committed: https://code.google.com/p/dart/source/detail?r=14178

Patch Set 1 #

Patch Set 2 : Fix two HTML tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -328 lines) Patch
M lib/collection/collection.dart View 1 chunk +1 line, -0 lines 0 comments Download
M lib/collection/collection_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A + lib/collection/splay_tree.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M lib/coreimpl/coreimpl.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/coreimpl/corelib_impl_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D lib/coreimpl/splay_tree.dart View 1 chunk +0 lines, -306 lines 0 comments Download
M tests/corelib/map_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/maps_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/corelib/splay_tree_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/indexeddb_2_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/html/postmessage_structured_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + tests/language/import_collection_no_prefix_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
D tests/language/import_core_impl_no_prefix_test.dart View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
8 years, 1 month ago (2012-10-26 13:03:49 UTC) #1
floitsch
LGTM.
8 years, 1 month ago (2012-10-26 13:12:23 UTC) #2
Anders Johnsen
PTAL, found two html tests that needed changes.
8 years, 1 month ago (2012-10-29 08:58:37 UTC) #3
Lasse Reichstein Nielsen
8 years, 1 month ago (2012-10-29 09:39:58 UTC) #4
SLGTM

Powered by Google App Engine
This is Rietveld 408576698