Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1130253005: Don't attempt to walk the native stack by default. (Closed)

Created:
5 years, 7 months ago by koda
Modified:
5 years, 7 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Don't attempt to walk the native stack by default. This was unintentially enabled by default as a consequence of https://codereview.chromium.org/1104323003/ BUG=23368 R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=45666

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M runtime/vm/profiler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/configurations_android.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gyp/configurations_make.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gyp/configurations_msvs.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gyp/configurations_xcode.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
koda
5 years, 7 months ago (2015-05-08 18:01:53 UTC) #1
Cutch
On 2015/05/08 18:01:53, koda wrote: The define in the gypis (on all configurations) should be ...
5 years, 7 months ago (2015-05-08 18:12:33 UTC) #2
koda
On 2015/05/08 18:12:33, Cutch wrote: > On 2015/05/08 18:01:53, koda wrote: > > The define ...
5 years, 7 months ago (2015-05-08 22:05:35 UTC) #3
Cutch
lgtm
5 years, 7 months ago (2015-05-08 22:06:06 UTC) #4
koda
5 years, 7 months ago (2015-05-08 22:34:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r45666 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698