Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 11301034: Add flush to HTTP output streams (Closed)

Created:
8 years, 1 month ago by Søren Gjesse
Modified:
8 years, 1 month ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add flush to HTTP output streams The flush method was missing on the HTTP output streams and was wrongly on the HTTP input streams. The call to flush is forwarded to the socket output stream (on which is is actually a noop). R=ager@google.com BUG=dart:6384 TEST=tests/standalone/io/http_advanced_test.dart Committed: https://code.google.com/p/dart/source/detail?r=14246

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -4 lines) Patch
M runtime/bin/http_impl.dart View 5 chunks +16 lines, -4 lines 0 comments Download
M tests/standalone/io/http_advanced_test.dart View 3 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Gjesse
8 years, 1 month ago (2012-10-30 08:21:38 UTC) #1
Mads Ager (google)
8 years, 1 month ago (2012-10-30 08:23:08 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698