Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 11301019: Don't depend on V8 when creating the SDK. (Closed)

Created:
8 years, 1 month ago by ahe
Modified:
8 years, 1 month ago
Reviewers:
ricow1, dgrove
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't depend on V8 when creating the SDK. Committed: https://code.google.com/p/dart/source/detail?r=14266

Patch Set 1 #

Patch Set 2 : Change what build bot builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M dart/dart.gyp View 1 2 chunks +10 lines, -1 line 0 comments Download
M dart/tools/bots/compiler.py View 1 1 chunk +15 lines, -1 line 0 comments Download
M dart/utils/compiler/compiler.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
With this change, I can build the SDK on Linux x64 with this command: ./tools/build.py ...
8 years, 1 month ago (2012-10-29 17:07:54 UTC) #1
dgrove
lgtm
8 years, 1 month ago (2012-10-29 17:11:31 UTC) #2
ahe
PTAL, uploaded a new patch set to change what the build bot builds. Otherwise, we ...
8 years, 1 month ago (2012-10-30 06:29:55 UTC) #3
ricow1
8 years, 1 month ago (2012-10-30 06:49:39 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698