Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1130003004: - Revert r45669 to address Windows issues. (Closed)

Created:
5 years, 7 months ago by Ivan Posva
Modified:
5 years, 7 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Revert r45669 to address Windows issues. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=45672

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -212 lines) Patch
M runtime/bin/builtin.dart View 12 chunks +146 lines, -190 lines 0 comments Download
M runtime/bin/builtin_gen_snapshot.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/builtin_natives.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/dartutils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/dartutils.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/bin/gen_snapshot.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M runtime/bin/vmservice/loader.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Ivan Posva
5 years, 7 months ago (2015-05-09 00:58:20 UTC) #2
Vyacheslav Egorov (Google)
rubberstamp lgtm
5 years, 7 months ago (2015-05-09 00:58:45 UTC) #3
Ivan Posva
5 years, 7 months ago (2015-05-09 00:59:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r45672 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698